-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HRMP
messages delivery for unregistered channels
#688
base: master
Are you sure you want to change the base?
Fix HRMP
messages delivery for unregistered channels
#688
Conversation
HRMP
for unregistered channelsHRMP
messages delivery for unregistered channels
Thank you for this PR but unfortunately this will break a few things. I made validation data to inject any para id coming from hrmp without relaychain which mean you can open the channel just by submitting and empty message |
Ok, but notice that there are other two changes in this PR that would be still applicable?
Can I revert HRMP changes and keep those two? Can you share what approach you will follow to address the issue? |
can you do another PR for this? |
I don't why need to build block |
Message is processed in the next block after being received. Without building an extra block I can not assert the expected events. |
but we already listen to |
Not sure if I understand, I think we are talking about different things. Soon, AssetHub runtimes will be using I am already using for my tests another runtime that implements |
Thanks, I wasn't aware. In that case we'll need to proper upgrade to |
if you can upload latest assethub genesis it will help me a lot |
I don't think know if we need any change yet. We don't use |
@NachoPal do you any example that doesn't work so I can look at? |
we don't need to change anything. parachain messages are injected into validation data |
this is the reason the messageQeueue needs an extra block paritytech/polkadot-sdk#3709 |
This is already fixed and can be closed |
This PR aims to fix HRMP messages delivery for unregistered HRMP channels. Previous solution of opening channels on the fly did not really work, as it required at least one of the Parachains with an open
EgressChannel
.Now, HRMP channels are expected to be opened in the Relay Chain.
Additionally, there are also a couple of improvements foreseen in upcoming runtime changes:
MessageQueue
is used